-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor from System.Drawing.Common to Skiasharp. #1538
Conversation
Download the artifacts for this pull request here: GUI:
CLI: |
Can't you just use wine? I usually do my work on utmt with wine and it works just fine except for a few offs |
That works for the GUI, but I don't want to make the core library require the use of wine. If you meant dev'ing using WINE - that's more painful, because i can't actually build the GUI. And running the whole build environment via wine is a huge PITA. |
Oh ok. |
* Restore WIP script changes * Finish removing/replacing of "System.Drawing" in all scripts (not tested) * Update MergeImages.csx * Update ImportMasks.csx --------- Co-authored-by: Miepee <[email protected]>
Opening this PR up for review. I did a very basic test via WINE and it worked as expected there.
|
So I tested this a few days ago and found that (for sure) SkiaSharp doesn't losslessly process PNG images, so unfortunately this probably won't be able to merge. (And it'll probably be superseded by #1870 and the PRs that follow it.) However, this is still really good reference for what CSX scripts we'll need to update after #1870 is merged, which I'm going to start working on. |
I will close this PR as its superseded as mentioned above. |
Description
This PR attempts to refactor from System.Drawing.Common to Skiasharp. Doing this successfully means, that we'll be finally able to bump the .NET version for the project and not make the project Windows only by doing so.
Fixes #875
Caveats
This is not finished yet
Notes
TODO: