Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add djLint to lint HTML #180

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Add djLint to lint HTML #180

merged 4 commits into from
Oct 28, 2024

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Oct 18, 2024 •
edited
Loading

No description provided.

@johannaengland johannaengland self-assigned this Oct 18, 2024
@johannaengland johannaengland force-pushed the workflows/critical-linting-ruff branch 2 times, most recently from 5062855 to 72f7a4d Compare October 22, 2024 07:54
Base automatically changed from workflows/critical-linting-ruff to main October 22, 2024 07:54
@johannaengland johannaengland added the blocked Another thing/issue has to be resolved before tackling this label Oct 23, 2024
@johannaengland johannaengland removed the blocked Another thing/issue has to be resolved before tackling this label Oct 23, 2024
lunkwill42
lunkwill42 requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was never part of the djLint discussions, but would like to take part in a discussion of what linter rules we would want to enable for this tool.

The PR looks mostly fine to me, just a couple of potential quirks...

pyproject.toml Outdated Show resolved Hide resolved
.github/workflows/lint.yml Show resolved Hide resolved
@lunkwill42 lunkwill42 mentioned this pull request Oct 24, 2024
Merged
@podliashanyk podliashanyk mentioned this pull request Oct 28, 2024
Merged
@johannaengland johannaengland added blocked Another thing/issue has to be resolved before tackling this and removed discussion labels Oct 28, 2024
@johannaengland johannaengland changed the base branch from main to add-meta October 28, 2024 12:51
@podliashanyk
Copy link
Contributor

I suggest dropping the H006 rule. We use Tailwind CSS to set size to the <img> and to calculate appropriate aspect-ratio.

@podliashanyk podliashanyk mentioned this pull request Oct 28, 2024
Merged
@johannaengland johannaengland changed the base branch from add-meta to main October 28, 2024 13:36
@johannaengland johannaengland removed the blocked Another thing/issue has to be resolved before tackling this label Oct 28, 2024
@johannaengland
Copy link
Contributor Author

We are temporarily ignoring D018 (Internal links urlpattern) until #186 is merged, just to get this PR in as soon as possible

@johannaengland johannaengland merged commit da2529c into main Oct 28, 2024
4 checks passed
@johannaengland johannaengland deleted the add-djlint branch October 28, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podliashanyk podliashanyk podliashanyk approved these changes

@elfjes elfjes Awaiting requested review from elfjes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees

@johannaengland johannaengland

Labels
lint/reformat
Projects
HTMXify Argus
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johannaengland @podliashanyk @lunkwill42 @hmpf