This repository has been archived by the owner on Nov 30, 2020. It is now read-only.
Support v1 monitors on MacOS with Metal #382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modified monitor compute shaders & controllers to support variable threadgroup size - Reduced monitor threadgroup size on Metal to stay under threadgroup size limit - Changed monitor target shader level & compatibility check to 4.5 since systems that support compute but not full 5.0 can still run monitors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #180
Issue was closed due to monitors being fixed on Metal in v2, but until v2 is declared stable it's useful to have working monitors in v1.
Summary: