Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/fix navigate #309

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Bug/fix navigate #309

merged 1 commit into from
Mar 31, 2024

Conversation

ralphgregorio
Copy link
Collaborator

Resolves # (issue)

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

UAT Steps (if applicable)

If your changes are hard to follow, please describe how to manually test your changes as if a user was testing your changes.

@ralphgregorio ralphgregorio changed the base branch from master to development March 31, 2024 05:28
@ralphgregorio ralphgregorio marked this pull request as ready for review March 31, 2024 05:28
Copy link

Backend Code Coverage Report

Overall Project 28.58% -2.17%
Files changed 88.14% 🍏

File Coverage
RawDataService.java 100% 🍏
WatchController.java 100% 🍏
Util.java 100% 🍏
UserService.java 93.83% -0.15% 🍏
ProcessedDataService.java 90.72% 🍏
UserDao.java 74.15% -6.21% 🍏
UserController.java 71.48% -28.52%
PredictedDataService.java 68.1% -31.9%
PredictedDataDao.java 42.75% 🍏
RawDataDao.java 37.46% 🍏
ProcessedDataDao.java 36.96% -1.15% 🍏
AppleWatchService.java 0.28% -0.17%
FitbitService.java 0.24% -0.14%
ProfileDeleteService.java 0%
LoginUserController.java 0% 🍏
ArchiveUtil.java 0% 🍏
DownloadUtil.java 0% 🍏
AccessGroupDao.java 0% 🍏
RoleDao.java 0% 🍏

Copy link
Collaborator

@kamalzrein kamalzrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, good job fixing the navigation error upon sign in and the incorrect password popup

@ralphgregorio ralphgregorio merged commit 5be4208 into development Mar 31, 2024
1 of 4 checks passed
@ralphgregorio ralphgregorio deleted the bug/fix-navigate branch March 31, 2024 05:29
Copy link

Frontend Code Coverage Report

Action wasn't able to generate report within GitHub comment limit. If you're facing this issue, please let me know by commenting under this issue.

Report generated by 🧪jest coverage report action from d7ddc14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants