fix(dm): Prevent creating duplicate conversations for users in multiple common servers/on reconnection #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m event for each guild)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AbdurrehmanSubhani
changed the title
mavisakalyan
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add guard to dm conversation creation (users having common servers, dm event for each guild)
Fixes:
#689
Discord Agent Bot goes through each member in guild and sends 'dmconnect' event to the connected user
connected user on receiving the 'dmconnect' creates a new conversation object, uses the discord user's userId as hash and adds it to the manager
so here since the userId is being used to create the conversation object key
a user with common servers with the bot will be sent twice with dmconnect (from each guild/server)
since this is dm, there must be no duplicate dm conversations for the same user