feat: Add default value for BaseAddress

VMelnalksnis · Jun 16, 2022 · e451c57 · e451c57
1 parent d391cb7
commit e451c57
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -40,7 +40,6 @@ jobs:
           --configuration Release
           --no-build
         env:
-          Nordigen__BaseAddress: https://ob.nordigen.com/
           Nordigen__SecretId: ${{ secrets.NORDIGEN_SECRET_ID }}
           Nordigen__SecretKey: ${{ secrets.NORDIGEN_SECRET_KEY }}
 

diff --git a/source/VMelnalksnis.NordigenDotNet/NordigenOptions.cs b/source/VMelnalksnis.NordigenDotNet/NordigenOptions.cs
@@ -15,7 +15,7 @@ public sealed record NordigenOptions
 
 	/// <summary>Gets the base address of the Nordigen API.</summary>
 	[Required]
-	public Uri BaseAddress { get; init; } = null!;
+	public Uri BaseAddress { get; init; } = new("https://ob.nordigen.com/");
 
 	/// <summary>Gets the secret ID used to create new access tokens.</summary>
 	[Required]

diff --git a/...VMelnalksnis.NordigenDotNet.DependencyInjection.Tests/ServiceCollectionExtensionsTests.cs b/...VMelnalksnis.NordigenDotNet.DependencyInjection.Tests/ServiceCollectionExtensionsTests.cs
@@ -20,7 +20,6 @@ public void AddNordigenDotNet_ShouldRegisterRequiredServices()
 		var configuration = new ConfigurationBuilder()
 			.AddInMemoryCollection(new List<KeyValuePair<string, string>>
 			{
-				new($"{NordigenOptions.SectionName}:{nameof(NordigenOptions.BaseAddress)}", "https://ob.nordigen.com/"),
 				new($"{NordigenOptions.SectionName}:{nameof(NordigenOptions.SecretId)}", $"{Guid.NewGuid():D}"),
 				new($"{NordigenOptions.SectionName}:{nameof(NordigenOptions.SecretKey)}", $"{Guid.NewGuid():N}"),
 			})