-
-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify supported dyes to allow co-existing with dye addon mods #4764
Specify supported dyes to allow co-existing with dye addon mods #4764
Conversation
Is there no way to somehow implement this fix into Dye Depot itself? |
The only way to fix this in dye depot I could think of, which would have been the alternative, is mixing into Botania and doing the same thing there. |
The only way to make the game less strict about hardcoded dyes is by not assuming that they are hardcoded, which this PR does. Dye Depot crashed with some other mods, but almost none directly on start time and most so far could be solved by mixing into one or maybe two specific method, in Botania there are a lot more places like you can see |
I don't see any mention of the Spectrolus in the changes. Did you test that as well? |
No, I have not changed how the Spectrolus works, it still only requires vanilla wool. But I've checked how it's implemented and since it simply counts the index up to 15 and then resets to 0, it will not cause any problems with dye addons. |
@PssbleTrngle: Could you please run |
Sorry for the late response, but it looks like you already took care of it, right? |
Yes. I'm going to give it a proper test later today and then merge it. |
Thank you very much and nice to know, did not even notice that |
This is a proposed fix for #4589
I extracted all required places which use
DyeColor.values()
and replaced it with a reference to a centralized location which manually specifies the vanilla dyes.This way, dye colors injected by mods like dye depot are simply ignored.