Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Voice API to use DynamicEndpoint #490

Merged
merged 7 commits into from
Oct 27, 2023
Merged

refactor: Voice API to use DynamicEndpoint #490

merged 7 commits into from
Oct 27, 2023

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Oct 24, 2023

This is the final PR in the long-running series of refactorings in the SDK to decouple the implementation of endpoints (and their tests) from the underlying Apache HttpClient library. In additional to reimplementing the endpoints, some further deprecations have been made in preparation for a more substantial refactoring - which would include breaking changes - in a future PR / release.

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Merging #490 (d061496) into main (8cfcf59) will increase coverage by 0.25%.
The diff coverage is 94.69%.

@@             Coverage Diff              @@
##               main     #490      +/-   ##
============================================
+ Coverage     93.62%   93.87%   +0.25%     
+ Complexity     2630     2590      -40     
============================================
  Files           393      380      -13     
  Lines          6665     6529     -136     
  Branches        429      431       +2     
============================================
- Hits           6240     6129     -111     
+ Misses          252      226      -26     
- Partials        173      174       +1     
Files Coverage Δ
...ain/java/com/vonage/client/incoming/CallEvent.java 100.00% <100.00%> (+13.33%) ⬆️
...in/java/com/vonage/client/incoming/DtmfResult.java 100.00% <ø> (ø)
...in/java/com/vonage/client/incoming/InputEvent.java 100.00% <100.00%> (+16.66%) ⬆️
...n/java/com/vonage/client/incoming/NotifyEvent.java 100.00% <100.00%> (ø)
...n/java/com/vonage/client/incoming/RecordEvent.java 100.00% <100.00%> (+16.66%) ⬆️
...c/main/java/com/vonage/client/incoming/Result.java 100.00% <ø> (ø)
src/main/java/com/vonage/client/voice/Call.java 99.02% <100.00%> (+1.75%) ⬆️
...c/main/java/com/vonage/client/voice/CallEvent.java 100.00% <100.00%> (+11.76%) ⬆️
...rc/main/java/com/vonage/client/voice/CallInfo.java 100.00% <100.00%> (+9.43%) ⬆️
...ain/java/com/vonage/client/voice/CallInfoPage.java 100.00% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

@SMadani SMadani merged commit 4751026 into main Oct 27, 2023
11 checks passed
@SMadani SMadani deleted the voice-refactor branch October 27, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants