Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Trusted Signals KVv2 support to W3C Spec #1340

Merged
merged 18 commits into from
Dec 19, 2024
Merged

Add Trusted Signals KVv2 support to W3C Spec #1340

merged 18 commits into from
Dec 19, 2024

Conversation

xtlsheep
Copy link
Contributor

@xtlsheep xtlsheep commented Nov 18, 2024 •
edited by pr-preview bot
Loading

Bidding signals:

  • GenerateBidInterestGroup
  • joinAdInterestGroup(group) method steps
  • build an interest group passed to generateBid
  • update interest groups
  • estimated size of an interest group
  • 14.1. Interest group
  • 14.6. Trusted bidding signals batcher

Scoring signals:

  • AuctionAdConfig
  • validate and convert auction ad config
  • 14.3. Auction config
  • 14.7. Trusted scoring signals batcher

General methods:

  • fetch trusted key value signals
  • Feature Detection
  • Update CORS preflight header

Preview | Diff

@JensenPaul JensenPaul added the spec Relates to the spec label Nov 22, 2024
@JensenPaul JensenPaul requested a review from qingxinwu November 22, 2024 15:34
qingxinwu
qingxinwu reviewed Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing.

spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Nov 27, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 2, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 2, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 2, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 3, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 5, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 5, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 5, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
xtlsheep
xtlsheep commented Dec 9, 2024
View reviewed changes
Copy link
Contributor Author

@xtlsheep xtlsheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve comments

@xtlsheep xtlsheep changed the title Add Trusted KVv2 Signals Support to spec.bs Resolve comments Dec 9, 2024
qingxinwu
qingxinwu reviewed Dec 11, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 11, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@qingxinwu
Copy link
Collaborator

The PR's title changed to a commit message. Please change it back.

@xtlsheep xtlsheep changed the title Resolve comments Add Trusted Signals KVv2 support to W3C Spec Dec 12, 2024
@xtlsheep
Copy link
Contributor Author

The PR's title changed to a commit message. Please change it back.

Weird, and done.

@xtlsheep xtlsheep closed this Dec 12, 2024
@xtlsheep xtlsheep reopened this Dec 12, 2024
qingxinwu
qingxinwu reviewed Dec 13, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 13, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 16, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 16, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 16, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 17, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
@qingxinwu
Copy link
Collaborator

qingxinwu commented Dec 17, 2024 •
edited
Loading

LGTM % the last few comments.

qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Show resolved Hide resolved
qingxinwu
qingxinwu reviewed Dec 18, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
qingxinwu
qingxinwu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@qingxinwu qingxinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please plan to work on the follow up PR that covers a few readability comments we discussed in this PR.

JensenPaul
JensenPaul reviewed Dec 19, 2024
View reviewed changes
spec.bs Outdated Show resolved Hide resolved
spec.bs Outdated Show resolved Hide resolved
@JensenPaul JensenPaul merged commit e72310c into WICG:main Dec 19, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Dec 19, 2024
@xtlsheep @github-actions
Add Trusted Signals KVv2 support to W3C Spec (#1340)
24c3a98 
SHA: e72310c
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JensenPaul JensenPaul JensenPaul left review comments

@qingxinwu qingxinwu qingxinwu approved these changes

Assignees
No one assigned
Labels
spec Relates to the spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xtlsheep @qingxinwu @JensenPaul