Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup

[MattMenke2]

Move lifetimeMs from GenerateBidInterestGroup to AuctionAdInterestGroup because of concerns about ambiguity and providing a high accuracy timer when executionMode allows multiple same-origin interest groups to share state.

Note that lifetimeMs was never provided to generateBid() in Chrome, anyways, I believe, so no consumers should be broken by this change.

---

Preview | Diff

[MattMenke2]

If there's a need for generateBid() to know the expiry, I think it would be better to provide it browserSignals, where there's no ambiguity and likely to be no confusion over its meaning.

More generally, I wonder if we should default to putting fields in AuctionAdInterestGroup unless they're really needed in GenerateBidInterestGroup (e.g., I'm skeptical the priorityVector or enableBiddingSignalsPrioritization are useful).

[qingxinwu]

If there's a need for generateBid() to know the expiry, I think it would be better to provide it browserSignals, where there's no ambiguity and likely to be no confusion over its meaning.

At least for now expiry is not used in generateBid(). Currently expiry is only used for IG maintanance (screenshot), so I think we're good here, before we want to pass expiry to generateBid().

More generally, I wonder if we should default to putting fields in AuctionAdInterestGroup unless they're really needed in GenerateBidInterestGroup (e.g., I'm skeptical the priorityVector or enableBiddingSignalsPrioritization are useful).

Good catch! Yes, that's desirable. I think I put priorityVector in GenerateBidInterestGroup just because I thought it was needed in generate bid. So feel free to fix these. Thanks!

[MattMenke2]

Good catch! Yes, that's desirable. I think I put priorityVector in GenerateBidInterestGroup just because I thought it was needed in generate bid. So feel free to fix these. Thanks!

I had assumed you put it there because that's what the explainer calls for, and that's what the code currently does. :)

[qingxinwu]

Good catch! Yes, that's desirable. I think I put priorityVector in GenerateBidInterestGroup just because I thought it was needed in generate bid. So feel free to fix these. Thanks!

I had assumed you put it there because that's what the explainer calls for, and that's what the code currently does. :)

Yeah your assumption sounds more aligned with why I did that :)

[MattMenke2]

Looking at the code, the only other thing we don't currently set is executionMode, I believe.