Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Guide] Creating a Multichain Connection with Web3Auth and React PnP no-modal SDK #654

Merged
merged 25 commits into from
Jun 6, 2024
Merged

[Guide] Creating a Multichain Connection with Web3Auth and React PnP no-modal SDK #654

merged 25 commits into from
Jun 6, 2024

Conversation

rtomas
Copy link
Contributor

@rtomas rtomas commented Mar 13, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Mar 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview ✅ 8 resolved Jun 6, 2024 4:21am

@rtomas rtomas changed the title Add guide multiple chains Add guide for multiple chains connection Mar 13, 2024
@rtomas rtomas marked this pull request as ready for review March 13, 2024 15:36
@yashovardhan yashovardhan force-pushed the master branch 2 times, most recently from c2e734e to 9245e42 Compare March 19, 2024 14:37
@shahbaz17 shahbaz17 changed the title Add guide for multiple chains connection [Guide] Creating a Multichain Connection with Web3Auth and React PnP no-modal SDK Apr 19, 2024
@rtomas rtomas requested a review from shahbaz17 May 14, 2024 17:00
shahbaz17
shahbaz17 requested changes May 15, 2024
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments on the preview. Please check once @rtomas

@rtomas rtomas requested a review from shahbaz17 May 15, 2024 16:21
@shahbaz17
Copy link
Member

https://web3auth-docs-git-add-guide-multiple-chains-web3auth.vercel.app/guides/pnp-no-modal-multichain

Why this is a dependency @rtomas ?

@rtomas
Copy link
Contributor Author

rtomas commented Jun 6, 2024 •
edited
Loading

https://web3auth-docs-git-add-guide-multiple-chains-web3auth.vercel.app/guides/pnp-no-modal-multichain

Why this is a dependency @rtomas ?

There is no need to approve that dependency. I already deleted.

shahbaz17
shahbaz17 approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shahbaz17 shahbaz17 merged commit df62fda into master Jun 6, 2024
1 of 2 checks passed
@shahbaz17 shahbaz17 deleted the add-guide-multiple-chains branch June 6, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahbaz17 shahbaz17 shahbaz17 approved these changes

Assignees

@rtomas rtomas

Labels
Guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rtomas @shahbaz17 @yashovardhan