Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPC Corekit] Update Quick Start guide #995

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[MPC Corekit] Update Quick Start guide #995

wants to merge 1 commit into from

Conversation

AyushBherwani1998
Copy link
Member

Motivation and Context

Jira Link: https://toruslabs.atlassian.net/browse/DEVREL-1085?atlOrigin=eyJpIjoiYzk4MDZjNTdiNTQ0NDcyZTgzZjZhMjUzNDI5MDgzZjIiLCJwIjoiaiJ9

Description

Revamp the MPC Core Kit guide

How has this been tested?

This has been tested locally

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code requires a db migration.

@vercel Vercel
Copy link

vercel bot commented Nov 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web3auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:02am

shahbaz17
shahbaz17 requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@shahbaz17 shahbaz17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @AyushBherwani1998

src/pages/guides/mpc-core-kit.mdx
```
### Log In With OAuth

To authenticate users using Single Page Application(SPA) flow, you can use the loginWithOAuth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's work on these descriptions to make it beginner friendly, similarly at different places, let's sync for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahbaz17 shahbaz17 shahbaz17 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Guide
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AyushBherwani1998 @shahbaz17