Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tortoise conversion coursecorequisite #569

Merged
merged 14 commits into from
Apr 11, 2022
Merged

Tortoise conversion coursecorequisite #569

merged 14 commits into from
Apr 11, 2022

Conversation

PhoenixTamaoki
Copy link
Contributor

@PhoenixTamaoki PhoenixTamaoki commented Apr 8, 2022 •
edited by lhain08
Loading

Issue

Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation

Database Changes/Migrations

If you added/modified a table, notify people of schema change here

Example:

Added table account_semester_selection for a mapping from a students account and semester to a class and section (aka class/section selections)

Test Modifications

Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)

Example:

Added test tests/api/db/test_classinfo.py:test_crn_uniqueness to ensure all classes returned from API call don't have repeat CRNs

Test Procedure

Show procedure to test functionality with a clear procedure

Example:

  1. Create a branch
  2. Commit a change to that branch
  3. Push branch
  4. Create Pull Request and fill in PR template

Photos

Show before and after, capture screenshot/gif of finished feature/bug

Additional Info

More info that would help people review your change

@lhain08 lhain08 changed the base branch from master to TortoiseConversion April 8, 2022 21:29
PhoenixTamaoki and others added 5 commits April 8, 2022 17:31
@PhoenixTamaoki
forgot to add last changes
9a7c272
@lhain08
pytest fixes
559e2bc
@lhain08
fixed tables init file
fbe73c5
@canghiskhan @lhain08
course session tortoise conversion first draft (#567)
b38cc2d 
* course session tortoise conversion first draft

* fixing some issue

* fixed fields

Co-authored-by: canghiskhan <calvinang@icloud>
Co-authored-by: Liam Haining <[email protected]>
Co-authored-by: Liam Haining <[email protected]>
@lhain08
merge
5347cbf
@lhain08 lhain08 merged commit 979b595 into TortoiseConversion Apr 11, 2022
@lhain08 lhain08 deleted the TortoiseConversion-coursecorequisite branch April 11, 2022 23:45
lhain08 added a commit that referenced this pull request Apr 11, 2022
@lhain08
Revert "Tortoise conversion coursecorequisite (#569)"
f4266ff 
This reverts commit 979b595.
@lhain08 lhain08 mentioned this pull request Apr 11, 2022
Merged
lhain08 added a commit that referenced this pull request Apr 11, 2022
@lhain08
Revert "Tortoise conversion coursecorequisite (#569)" (#573)
93db114 
This reverts commit 979b595.
@lhain08 lhain08 restored the TortoiseConversion-coursecorequisite branch April 11, 2022 23:48
@lhain08 lhain08 deleted the TortoiseConversion-coursecorequisite branch April 11, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ops — Create Pull Request template
3 participants
@PhoenixTamaoki @lhain08 @canghiskhan