Tortoise conversion coursecorequisite #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhain08
added a commit
that referenced
this pull request
Apr 16, 2022
* updated course model * fixed for pytests * fixed for pytests * workflows * fixed for pytests * fixed for pytests * pytest fixings * pytest fixes * course session tortoise conversion first draft (#567) * course session tortoise conversion first draft * fixing some issue * fixed fields Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: Liam Haining <[email protected]> Co-authored-by: Liam Haining <[email protected]> * Tortoise conversion coursecorequisite (#574) * converted course_corequisite * converted course_corequisite * forgot to add last changes * fixed tables init file Co-authored-by: PhoenixTamaoki <[email protected]> * Prerequisite model (#570) * beginning tests on course models * progress * bulk upload tests now working * removed database migrations, dependance on sql alchemy * fixed corequisite * Added checks for coreqs Co-authored-by: canghiskhan <[email protected]> Co-authored-by: canghiskhan <calvinang@icloud> Co-authored-by: PhoenixTamaoki <[email protected]> Co-authored-by: franchen28 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Note which issue number(s) this Pull Request closes. All pull requests should close an issue, if one does not exists, make one. This helps us plan and discuss before we decide on implementation
Example:
Database Changes/Migrations
If you added/modified a table, notify people of schema change here
Example:
Test Modifications
Note added unit/integration tests: (all backend changes should contain unit/integration tests with pytest)
Example:
Test Procedure
Show procedure to test functionality with a clear procedure
Example:
Photos
Show before and after, capture screenshot/gif of finished feature/bug
Additional Info
More info that would help people review your change