Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ip_public): Exclude IPv4 Link Local #885

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

jfagoagas
Copy link
Contributor

  • Please check if the PR fulfils these requirements
  • Tests for the changes have been added
  • Docs have been added / updated
  • All CI checks are green
(venv) ➜  time python -m pytest tests/plugins/ip_public_test.py       
================================================================================ test session starts ================================================================================
platform darwin -- Python 3.11.10, pytest-7.4.3, pluggy-1.5.0
rootdir: /Users/pepin/Desktop/Code/Prowler/detect-secrets
collected 17 items                                                                                                                                                                  

tests/plugins/ip_public_test.py .................                                                                                                                             [100%]

================================================================================ 17 passed in 0.09s =================================================================================
python -m pytest tests/plugins/ip_public_test.py  0.24s user 0.06s system 98% cpu 0.302 total
  • What kind of change does this PR introduce?
    This PR fixes a bug with the IPPublicDetector since an IPv4 Link Local address was being flagged as public.

  • What is the current behaviour?
    IPv4 Link Local addresses 169.254/16 are being flagged as public.

  • What is the new behaviour (if this is a feature change)?
    Exclude 169.254/16 from the IPPublicDetector.

  • Does this PR introduce a breaking change?
    No.

  • Other information:

@jfagoagas
Copy link
Contributor Author

Pinning @lorenzodb1 @KevinHock @domanchi to see if this can get a review soon. Thanks in advance!!

Copy link
Contributor

@lorenzodb1 lorenzodb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@lorenzodb1 lorenzodb1 merged commit 7b162a7 into Yelp:master Oct 7, 2024
15 checks passed
@jfagoagas jfagoagas deleted the fix_ip_public_link_local branch October 7, 2024 20:48
@jfagoagas
Copy link
Contributor Author

Hello @lorenzodb1 is there any ETA to have this included in a new release? Is something we do really need and we are trying not to vendor/fork the repository.

Thank you!

@jfagoagas
Copy link
Contributor Author

jfagoagas commented Nov 11, 2024

@lorenzodb1 @KevinHock @domanchi Any updates for a new release? Thanks!

@lorenzodb1
Copy link
Contributor

@jfagoagas we're planning to make a release soon. Either @jpdakran or myself will make one. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants