Copyright year calculating method #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@hjx754242756 is attempting to deploy a commit to the zl-asica's projects Team on Vercel. A member of the Team first needs to authorize it. |
ZL-Asica
reviewed
Dec 12, 2024
| @@ -19,7 +19,7 @@ const Footer = ({ config }: FooterProperties) => { | |||
| <div className='mx-auto max-w-7xl px-4 py-4 text-center'> | |||
| {!isHomePage && <SocialMediaLink socialMedia={config.socialMedia} />} | |||
| <p className='text-[var(--gray)]'> | |||
| {`© ${config.startYear && config.startYear < currentYear ? `${config.startYear} - ` : ''}${currentYear} ${config.title}`} | |||
There was a problem hiding this comment.
Type error: 'config.startYear' is possibly 'null'.
That's why we need to make sure config.startYear before we do the comparison.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just short-circuiting it.