Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
Shion1305
force-pushed
the
38-マイルストーン編集用のfetchロジックを作る
branch
from
062838c to
45d3264
Compare
Shion1305
requested changes
Mar 15, 2024
src/hooks/useFetchUser.ts
Outdated
| } from "../../proto/typescript/pb_out/main"; | ||
| import useApiPBClient from "@/hooks/useApiPBClient"; | ||
|
|
||
| const protobuf = require("protobufjs"); |
There was a problem hiding this comment.
Suggested change
| const protobuf = require("protobufjs"); |
src/hooks/useFetchMilestone.ts
Outdated
|
|
||
| import useApiPBClient from "@/hooks/useApiPBClient"; | ||
|
|
||
| const protobuf = require("protobufjs"); |
There was a problem hiding this comment.
Suggested change
| const protobuf = require("protobufjs"); |
src/hooks/useImageUploder.ts
Outdated
Comment on lines
2
to
36
| const protobuf = require("protobufjs"); | ||
|
|
||
| const useImageUploder = () => { | ||
| const upload = async (image: File): Promise<string | void> => { | ||
| const token = localStorage.getItem("token"); | ||
|
|
||
| const ImageUploadRequest = protobuf.roots.default.lookupType( | ||
| "main.ImageUploadRequest", | ||
| ); | ||
| const payload = { image: image }; | ||
| const errMsg = ImageUploadRequest.verify(payload); | ||
| if (errMsg) throw Error(`ImageUploadRequest: ${errMsg}`); | ||
|
|
||
| const imageUpload = ImageUploadRequest.create(payload); | ||
| const buffer = ImageUploadRequest.encode(imageUpload).finish(); | ||
| await axios | ||
| .post(`${process.env.BACKEND_DOMAIN}/api/v1/image/upload`, buffer, { | ||
| headers: { | ||
| Authorization: `token ${token}`, | ||
| }, | ||
| }) | ||
| .then((response) => { | ||
| const ImageUploadResponse = protobuf.roots.default.lookupType( | ||
| "main.ImageUploadResponse", | ||
| ); | ||
| const res = ImageUploadResponse.decode(new Uint8Array(response.data)); | ||
| return res; | ||
| }) | ||
| .catch((error) => { | ||
| console.log(error); | ||
| }); | ||
| }; | ||
|
|
||
| return { upload }; | ||
| }; |
There was a problem hiding this comment.
Suggested change
| const protobuf = require("protobufjs"); | |
| const useImageUploder = () => { | |
| const upload = async (image: File): Promise<string | void> => { | |
| const token = localStorage.getItem("token"); | |
| const ImageUploadRequest = protobuf.roots.default.lookupType( | |
| "main.ImageUploadRequest", | |
| ); | |
| const payload = { image: image }; | |
| const errMsg = ImageUploadRequest.verify(payload); | |
| if (errMsg) throw Error(`ImageUploadRequest: ${errMsg}`); | |
| const imageUpload = ImageUploadRequest.create(payload); | |
| const buffer = ImageUploadRequest.encode(imageUpload).finish(); | |
| await axios | |
| .post(`${process.env.BACKEND_DOMAIN}/api/v1/image/upload`, buffer, { | |
| headers: { | |
| Authorization: `token ${token}`, | |
| }, | |
| }) | |
| .then((response) => { | |
| const ImageUploadResponse = protobuf.roots.default.lookupType( | |
| "main.ImageUploadResponse", | |
| ); | |
| const res = ImageUploadResponse.decode(new Uint8Array(response.data)); | |
| return res; | |
| }) | |
| .catch((error) => { | |
| console.log(error); | |
| }); | |
| }; | |
| return { upload }; | |
| }; | |
| const useImageUploder = () => { | |
| const upload = async (image: File): Promise<string | void> => { | |
| const token = localStorage.getItem("token"); | |
| }; | |
| return { upload }; | |
| }; |
src/hooks/useFetchMilestone.ts
Outdated
| newMilestoen: MilestoneCreateRequest, | ||
| ): Promise<MilestoneUpdateResponse> => { | ||
| return await client | ||
| .put(`/milestone/${newMilestoen.milestone?.milestoneId}`, newMilestoen) |
There was a problem hiding this comment.
clientなんですが 現状 /api/v1/ つけないといけない仕様になっています..
[Add] image uploader
1 similar comment
Shion1305
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRで実装される機能
PRで修正される機能
レビューをお願いしたいポイント