Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(markdown-docx): add strong transformer - #397 #417

Merged
merged 1 commit into from
Jun 23, 2021
Merged

feat(markdown-docx): add strong transformer - #397 #417

merged 1 commit into from
Jun 23, 2021

Conversation

K-Kumar-01
Copy link
Collaborator

@K-Kumar-01 K-Kumar-01 commented Jun 23, 2021 •
edited by algomaster99
Loading

Signed-off-by: k-kumar-01 [email protected]

Reference #397

Changes

  • Rules: STRONG_RULE
  • Class in definedNodes
  • Transformer(CiceroMark JSON <-> OOXML)
  • Corresponding Test

Screenshots or Video

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname

@K-Kumar-01
feat: add strong transformer
3993572 
Rules: STRONG_RULE
Class in definedNodes
Transformer(CiceroMark JSON <-> OOXML)
Corresponding Test

Signed-off-by: k-kumar-01 <[email protected]>
@K-Kumar-01 K-Kumar-01 requested a review from algomaster99 June 23, 2021 12:59
algomaster99
algomaster99 reviewed Jun 23, 2021
View reviewed changes
packages/markdown-docx/src/CiceroMarkToOOXML/rules.js
<w:r>
<w:rPr>
<w:b />
<w:bCs />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this tag for? <w:b> is already there. Do we need <w:bCs>` too?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bCs is used for complex script.
This is the reason why I have used it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we using complex scripts? All templates are in English only, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as i remember, one of the templates used some different language. The template was probably car rental. Besides, it might be possible that later templates might be created in different languages. So i guess there would be no harm keeping this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, it might be possible that later templates might be created in different languages.

Good point. In that case, we can keep it.

@algomaster99
Copy link
Member

Screenshot from 2021-06-23 19-22-29
Don't use the "fix" prefix here. GitHub will close the issue when this PR will be merged.

@algomaster99 algomaster99 merged commit 0bd57ec into algoo-ooxml Jun 23, 2021
@algomaster99 algomaster99 deleted the k-kumar-01/i397/strong-transformer branch June 23, 2021 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algomaster99 algomaster99 algomaster99 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@K-Kumar-01 @algomaster99