Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add objectFormat setting to allow init()ing a repo with sha256 #1945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add objectFormat setting to allow init()ing a repo with sha256 #1945

wants to merge 1 commit into from
+120 −39

Conversation

yangskyboxlabs
Copy link

Addresses #1843

@yangskyboxlabs yangskyboxlabs requested a review from a team as a code owner October 15, 2024 22:31
yangskyboxlabs
yangskyboxlabs commented Oct 15, 2024
View reviewed changes
dist/index.js
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure why there's such a huge diff on index.js. Should I be building with a specific node/TypeScript version to avoid this?

yangskyboxlabs
yangskyboxlabs commented Oct 16, 2024
View reviewed changes
__test__/git-command-manager.test.ts
)

await git.init({objectFormat: 'sha256'})
// await git.init({objectFormat: undefined})
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// await git.init({objectFormat: undefined})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marissareyes80 marissareyes80 marissareyes80 approved these changes

@mScott224 mScott224 mScott224 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangskyboxlabs @mScott224 @marissareyes80