Overwrite Extraction with Original Folder Structure #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
activescott
reviewed
Dec 19, 2024
There was a problem hiding this comment.
@mega5800 Great work here. I love the tests! I added a comment to one line that I think we should consider. Let me know what you think.
…ter description and readability
activescott
requested changes
Dec 24, 2024
Comment on lines
+42
to
+81
| if (isFlatExtractionRequired(commandArgument)) | ||
| { | ||
| extractionMode = ExtractionMode.OverwriteFlatExtraction; | ||
| if (commandArgument[commandArgument.Length - 1] == 'o') | ||
| { | ||
| extractionMode = ExtractionMode.OverwriteFlatExtraction; | ||
| } | ||
| else if (commandArgument[commandArgument.Length - 1] == 'r') | ||
| { | ||
| extractionMode = ExtractionMode.RenameFlatExtraction; | ||
| } | ||
| } | ||
| else if (commandArgument[commandArgument.Length - 1] == 'r') | ||
| else | ||
| { | ||
| extractionMode = ExtractionMode.RenameFlatExtraction; | ||
| if (isRegularExtracionWithOverwriteRequired(commandArgument)) | ||
| { | ||
| extractionMode = ExtractionMode.OverwriteExtraction; | ||
| } | ||
| } | ||
|
|
||
| return extractionMode; | ||
| } | ||
|
|
||
| private bool isFlatExtractionRequired(string commandArgument) | ||
| { | ||
| bool flatExtractionRequiredFlag = false; | ||
|
|
||
| if (commandArgument.Length > 1) | ||
| { | ||
| flatExtractionRequiredFlag = commandArgument[1] == 'f'; | ||
| } | ||
|
|
||
| return flatExtractionRequiredFlag; | ||
| } | ||
|
|
||
| private bool isRegularExtracionWithOverwriteRequired(string commandArgument) | ||
| { | ||
| bool regularExtracionWithOverwriteFlag = commandArgument[commandArgument.Length - 1] == 'o'; | ||
|
|
||
| return regularExtracionWithOverwriteFlag; | ||
| } |
There was a problem hiding this comment.
Please see mega5800#1 for a simplification here.
| /// </summary> | ||
| None, | ||
| Default, |
There was a problem hiding this comment.
NOTE: Changing this would be a breaking change to anyone using the library. I don't think that's a problem since this is the LessMsi.Cli library and to my knowledge only people depend on the Lessmsi.Core library. I am okay making this change, just want to point it out.
|
also, please update the branch (you can use the github ui to update it and then pull it again locally from your own branch). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👍🎉 First off, thanks for taking the time to contribute! 🎉👍
Please fill out the following checklist:
If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!
Hello @activescott.
I took care of this ticket.
I implemented a logic for detecting and deleting any duplicate files after a file extraction.
I added some tests to cover this feature from different points of view, such as regular extraction, extraction with a defined path and an extraction with specific files.
The newly added tests use a new MSI file I added called “AppleMobileDeviceSupport64.msi”.
I know this file contains duplicate files, thus making it a prefect match for testing this new overwrite extraction.
I’d greatly appreciate if you could review my pull request.
Thank you.