Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to biome #100

Merged
merged 3 commits into from
Aug 18, 2024
Merged

Migrate to biome #100

merged 3 commits into from
Aug 18, 2024

Conversation

Ayc0
Copy link
Collaborator

@Ayc0 Ayc0 commented Aug 18, 2024

Rome has been discontinued and renamed Biome, see https://biomejs.dev/blog/annoucing-biome/

This PR aims to update to Biome to have the last up-to-date config. It includes:

  • installing @biomejs/biome v1.8.0
  • renaming rome.json into biome.jsonc
  • disable the rules complexity/noForEach & correctness/useExhaustiveDependencies (still set as warning)
  • run lint-fix on the codebase will all the newest fixes (like enforcing import type or import order, etc.)
  • update GitHub Action following https://biomejs.dev/recipes/continuous-integration/#github-actions

Copy link

vercel bot commented Aug 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ada-url ❌ Failed (Inspect) Aug 18, 2024 7:07am

@Ayc0
Copy link
Collaborator Author

Ayc0 commented Aug 18, 2024

The deployment has failed, but when I run the build locally, I have this error which doesn't seem related to this PR:

View logs
Failed to compile.

./node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/lucide-react.js
Module not found: Can't resolve './node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/icons/alert-triangle'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./components/icons.tsx
./components/mode-toggle.tsx

./node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/lucide-react.js
Module not found: Can't resolve './node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/icons/alert-triangle'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./components/icons.tsx
./app/page.tsx

./node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/lucide-react.js
Module not found: Can't resolve './node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/icons/arrow-right'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./components/icons.tsx
./components/mode-toggle.tsx

./node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/lucide-react.js
Module not found: Can't resolve './node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/icons/arrow-right'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./components/icons.tsx
./app/page.tsx

./node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/lucide-react.js
Module not found: Can't resolve './node_modules/.pnpm/[email protected][email protected]/node_modules/lucide-react/dist/cjs/icons/check'

https://nextjs.org/docs/messages/module-not-found

Import trace for requested module:
./components/icons.tsx
./components/mode-toggle.tsx


> Build failed because of webpack errors
- info Creating an optimized production build . ELIFECYCLE  Command failed with exit code 1.

I found lucide-icons/lucide#1482 that is referencing a similar error (seems related to next itself)

#101 should fix this compilation error

@Ayc0
Copy link
Collaborator Author

Ayc0 commented Aug 18, 2024

@anonrig I don't think I have the right to merge the PR
Is there anything else I need to do to be able to merge it?

@anonrig anonrig merged commit 7600c21 into ada-url:main Aug 18, 2024
2 of 3 checks passed
@Ayc0 Ayc0 deleted the migrate-to-biome branch August 18, 2024 14:06
@Ayc0
Copy link
Collaborator Author

Ayc0 commented Aug 18, 2024

Thank you \o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants