Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playground page to astro docs #111

Merged
merged 8 commits into from
Sep 26, 2024
Merged

Add playground page to astro docs #111

merged 8 commits into from
Sep 26, 2024

Conversation

rndexe
Copy link
Contributor

@rndexe rndexe commented Sep 2, 2024

Tasklist

  • Add astro integration for react
  • Modify shadcn components to use utils.ts without site config from next
  • Replace next specfic hooks for searchParams and replaceState with vanilla js utilities
  • Add support for tailwind/ Replace tailwind classNames with vanilla css
  • Add dropdown to select ada version for the playground

Copy link

vercel bot commented Sep 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ada-url ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 1:51pm

@anonrig
Copy link
Member

anonrig commented Sep 2, 2024

Is it easy for you to add versioning to this playground? Basically, changing the version should change the WASM file. If we can add it, I can build Ada wasm and add those multiple files in a follow up PR

@anonrig
Copy link
Member

anonrig commented Sep 2, 2024

we can land it with tailwindcss and remove it in a follow up pull request

@rndexe
Copy link
Contributor Author

rndexe commented Sep 2, 2024

I don't understand the request, it is using the same wasm file as the current site. Do we need to add a choice for which wasm file to pick up? Also would it be a code based config or a url based one?

@rndexe
Copy link
Contributor Author

rndexe commented Sep 2, 2024

Also right now tailwind is not setup to work with the astro site. I'm not sure if it'd be conflicting with the current tailwind config as it is in the same root.

Other components added earlier are also using vanilla css instead of tailwind.

@anonrig
Copy link
Member

anonrig commented Sep 2, 2024

Let's land it with vanilla css then. I was thinking about adding a dropdown to playground with different versions (such as 2.9.0, 2.9.1 etc) which changes the version of Ada. Currently we have 1 version (only 1 wasm file) but if we add the versioning support it would be super easy to add more.

client:load renders HTML on the server/build and loads and hydrates js on the client,
as opposed to client:only which loads, renders and hydrates only on the client
@rndexe
Copy link
Contributor Author

rndexe commented Sep 5, 2024

Hello, I've added a drop-down for different versions. If you could add the wasm files and the corresponding wasm.js I can test the changes out.

@anonrig anonrig merged commit 6eb491d into ada-url:main Sep 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants