Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LSM9DS1 I2C Component #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Acoustics123
Copy link

This pull request adds the Adafruit 9-DOF Accel/Mag/Gyro+Temp Breakout Board - LSM9DS1 board to Wippersnapper_Components.

Product URL: https://www.adafruit.com/product/3387

@tyeth
Copy link
Contributor

tyeth commented Feb 16, 2024

Hi @Acoustics123 👋 Thanks for submitting this pull request, and welcome to GitHub!

There are a couple of extra fields required (like published false for in-development components) in the component JSON, and we've recently setup product images to be pulled from the Adafruit store if not uploaded (which is now our preference for Adafruit components).

These requirements are usually checked by CI(continuous integration) in GitGub Actions, also seen in the Checks tab/box, but these are disabled for first time contributers (until a maintainer allows the first CI run which I've now done for you)

Take a look at something like the vl53l0x i2c component as an example, or here's one I'm adding soon in another PR: https://github.com/adafruit/Wippersnapper_Components/pull/183/files

Are you also planning to add the corresponding driver to the main firmware repository https://github.com/adafruit/Adafruit_Wippersnapper_Arduino ? If not then we'll probably leave this unmerged untill the driver gets started/done too by us (I've got one and it's on my long list so am happy to help) or someone (yourself or another contributor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants