SITES-26750 Accordion : Content editor dialog is adding "None" twice in Expanded Items field

[RaduADumitru]

Q	A
Fixed Issues?	Fixes #1, Fixes #2
Patch: Bug Fix?	Yes
Minor: New Feature?	No
Major: Breaking Change?	No
Tests Added + Pass?	No
Documentation Provided	Yes (code comments and or markdown)
Any Dependency Changes?	No
License	Apache License, Version 2.0

Steps to reproduce bug:

1. Add an accordion component and include three items, such as text components.
2. Navigate to the properties tab and select the "Single item expansion" checkbox.
3. Open the dropdown menu, which displays all three items along with an extra "None" option.
4. Go to the Items tab and delete one item, for example, item 2.
5. Return to the properties tab and open the dropdown menu again, observing that there are now two "None" options.

This is caused by the way expanded select is updated: it removes all the current items where value is not "", then adds "None", then readds items from children editor. Issue is fixed by also cleaning up "None" value, whereas this didn't happen before. Adapts fix from #2857

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.15%. Comparing base (081c26d) to head (7ba51e7).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2890   +/-   ##
=========================================
  Coverage     87.15%   87.15%           
  Complexity     2692     2692           
=========================================
  Files           235      235           
  Lines          7188     7188           
  Branches       1100     1100           
=========================================
  Hits           6265     6265           
  Misses          365      365           
  Partials        558      558           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RaduADumitru]

2 more possible issues I noticed with the original fix, upon further inspection:

• The check for removing "None" option doesn't account for localization: if the localized value of "None" is different than the original, then the "None" option won't be removed. Could be fixed by checking for the localized value in the check instead
• The check, since it uses includes() instead of strict equality, can also accept values that simply contain "None" in the text but are not this exact value. Could be fixed by using strict equality instead of includes

Will rectify

[RaduADumitru]

Changed approach to do full cleanup before reinitializing expanded select, including of "None" element. Couldn't see any elements of value "" which we do want to keep, other than "None" element. Would be IMO the safest way to avoid other unforeseen problems, such as if other elements with value "" are added.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud