Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include item mimeType #260

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat: include item mimeType #260

merged 1 commit into from
Oct 2, 2023

Conversation

tripodsan
Copy link
Contributor

include mimeType

@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited
Loading

Codecov Report

Merging #260 (159ee46) into main (497f81a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #260   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines          799       800    +1     
=========================================
+ Hits           799       800    +1
Files Coverage Δ
src/GoogleClient.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dominique-pfister
dominique-pfister approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@dominique-pfister dominique-pfister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, is it still required that dependent projects need to alter their expected nocks as well?

@tripodsan
Copy link
Contributor Author

Good, is it still required that dependent projects need to alter their expected nocks as well?

probably... we can make it breaking...

@tripodsan tripodsan merged commit 6bd1a5a into main Oct 2, 2023
5 checks passed
@tripodsan tripodsan deleted the include-mimetype branch October 2, 2023 15:32
github-actions bot pushed a commit that referenced this pull request Oct 2, 2023
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
b95f3a6 
# [3.0.0](v2.3.14...v3.0.0) (2023-10-02)

### Features

* include item mimeType ([#260](#260)) ([6bd1a5a](6bd1a5a))

### BREAKING CHANGES

* getItemsFromPath() now includes the mimetype for the items. tests might fail.
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dominique-pfister
Copy link
Contributor

dominique-pfister commented Oct 2, 2023 •
edited
Loading

Good, is it still required that dependent projects need to alter their expected nocks as well?

probably... we can make it breaking...

I think the tests in the dependent services will break as soon as they reference the new dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominique-pfister dominique-pfister dominique-pfister approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tripodsan @dominique-pfister