fix: Restore "fix: nested lists roundtrip (#530)" #556
+92
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 88392b9.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 8 +1
Lines 797 825 +28
Branches 1 1
=========================================
+ Hits 797 825 +28 ☔ View full report in Codecov by Sentry. |
--------- Co-authored-by: Dirk <[email protected]>
|
This PR will trigger a patch release when merged. |
buuhuu
changed the title
|
FWIW: We (DA) would love to have this merged sooner rather than later. |
auniverseaway
approved these changes
Dec 4, 2024
|
@buuhuu did you check with experience-league if their code now works with collapsed lists? |
|
I tested this with their dev env, but probably worth another iteration. |
mokimo
approved these changes
Dec 10, 2024
|
@tripodsan @buuhuu any update on this? This would be great to have. Otherwise we'll need to fix this in multiple blocks on our end which ups the risks of uncaught regressions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores commit e27ba08 which had been reverted in 88392b9.
The problem this caused last time with experience league got addressed, however we should do another round of testing.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Fixes #529
Thanks for contributing!