Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudflare): Support Cloudflare Logging #236

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

bosschaert
Copy link
Collaborator

For Cloudflare logging, we just need to log to the console.

A typical log message to the console looks like this:

{"time":1701172800001,"host":"example.com","url":"https://somehost.somedomain.com/.rum/1","user_agent":"desktop","referer":null,"weight":2,"id":"id123","CLS":1,"LCP":1,"FID":4}

Related Issues

Fixes: #230

Copy link

This PR will trigger a minor release when merged.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (e057540) 97.34% compared to head (14e652b) 96.82%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/console-logger.mjs 90.74% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   97.34%   96.82%   -0.52%     
==========================================
  Files           8        9       +1     
  Lines         603      662      +59     
  Branches       73       81       +8     
==========================================
+ Hits          587      641      +54     
- Misses         13       17       +4     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bosschaert bosschaert requested a review from trieloff November 28, 2023 13:11
@bosschaert bosschaert marked this pull request as ready for review November 28, 2023 15:38
- regenerated package-lock
@bosschaert
Copy link
Collaborator Author

Thx! I'll update the tests to increase the coverage before I merge.

@bosschaert bosschaert merged commit 310f8ef into main Nov 29, 2023
5 of 7 checks passed
@bosschaert bosschaert deleted the console-logger branch November 29, 2023 11:41
trieloff pushed a commit that referenced this pull request Nov 29, 2023
# [2.5.0](v2.4.0...v2.5.0) (2023-11-29)

### Features

* **cloudflare:** Support Cloudflare Logging ([#236](#236)) ([310f8ef](310f8ef)), closes [#230](#230)
@trieloff
Copy link
Contributor

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Cloudflare Logging
2 participants