Merge pull request #309 from vdua/main

bug: form id is not getting sent correctly in source selector
adobe · Oct 22, 2024 · 522344a · 522344a
2 parents 006d4c2 + 9d21c60
commit 522344a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/modules/dom.js b/modules/dom.js
@@ -60,8 +60,9 @@ function isButton(el) {
 }
 
 function getSourceContext(el) {
-  if (el.closest('form')) {
-    return `form${el.id ? `#${el.id}` : ''}`;
+  const formEl = el.closest('form');
+  if (formEl) {
+    return `form${formEl.id ? `#${formEl.id}` : ''}`;
   }
   const block = el.closest('.block[data-block-name]');
   if (block) return `.${block.getAttribute('data-block-name')}`;

diff --git a/test/unit/dom.sourceSelector.test.html b/test/unit/dom.sourceSelector.test.html
@@ -18,6 +18,9 @@
     <input type="checkbox" class="a-checkbox"></input>
     <textarea class="a-textarea"></textarea>
     <input class="a-none"></input>
+    <div id="form-element">
+      <input type="text" class="a-text-inside-div"></input>
+    </div>
   </form>
 
   <form id="b-form">
@@ -53,6 +56,7 @@
           expect(sourceSelector(document.querySelector('input[type="checkbox"'))).to.be.equal('form#a-form input[type=\'checkbox\'].a-checkbox');
           expect(sourceSelector(document.querySelector('input.a-none'))).to.be.equal('form#a-form input[type=\'\'].a-none');
           expect(sourceSelector(document.querySelector('textarea'))).to.be.equal('form#a-form textarea.a-textarea');
+          expect(sourceSelector(document.querySelector('input.a-text-inside-div'))).to.be.equal('form#a-form input[type=\'text\'].a-text-inside-div');
 
           expect(sourceSelector(document.querySelector('.a-block'))).to.be.equal('.a-block');
           expect(sourceSelector(document.querySelector('#a-div-in-block'))).to.be.equal('.a-block #a-div-in-block');