missingresource 1x #130
Merged
missingresource 1x #130
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trieloff
commented
Mar 4, 2024
•
trieloff
commented
- feat(resources): add missingresource checkpoint behind feature toggle
|
This PR will trigger a minor release when merged. |
chicharr
approved these changes
Mar 4, 2024
| if (window.origin === 'business.adobe.com') { | ||
| // feature flagged for now | ||
| list.getEntries() | ||
| .filter((entry) => entry.responseStatus === 404) |
There was a problem hiding this comment.
do we want to filter as well by origin of the resource?, i.e. we only report missing resources that are in the same domain than the current one.
There was a problem hiding this comment.
Let's see how it goes after we have the report
|
Sibling is #131 |
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.