Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable reportAllChanges for all projects #152

Merged
merged 1 commit into from
May 7, 2024
Merged

feat: enable reportAllChanges for all projects #152

merged 1 commit into from
May 7, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Apr 17, 2024

The feature (https://github.com/GoogleChrome/web-vitals?tab=readme-ov-file#report-the-value-on-every-change) has been tested on blog.adobe.com and revolt.tv for a couple a weeks. On those 2 sites, we could observe an increase of reported number of LCP and CLS checkpoints in the RUM data. In some cases, it is up to 4x times more reported LCP events!

  • LCP
    • there is only a trivial number (less than 1%) of extra requests (like 2 LCPs captured)
  • CLS
    • this changes how the CLS is collected - every CLS event will fire a request (while aggregated before) - before the change, we saw 9% of sessions where CLS was captured multiple times. This number now goes to 25%. Nothing critical, just a little bit more entries to be filtered out in the data reporting.

I think it is time to enable the feature on all projects.

@kptdobe kptdobe requested review from trieloff and ekremney April 17, 2024 12:39
@trieloff trieloff merged commit 4b342f5 into 1.x May 7, 2024
5 checks passed
Copy link

github-actions bot commented May 7, 2024

🎉 This PR is included in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kptdobe kptdobe deleted the report-all branch May 7, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants