Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add referer #190

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix: add referer #190

merged 1 commit into from
Jun 7, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Jun 7, 2024

Since there is no test, I do not know what the sanitizeURL may have been used for... but several things wrong with that code:

  • the sanitizeURL property is set with a function (function not executed...)
  • the sanitizeURL property is filter out because it is not in the KNOWN_PROPERTIES

Conclusion: no sanitizeURL but also no referer

@kptdobe kptdobe requested review from chicharr and trieloff and removed request for chicharr June 7, 2024 10:30
@kptdobe kptdobe merged commit 68b75d6 into main Jun 7, 2024
5 checks passed
@kptdobe kptdobe deleted the missing-referer branch June 7, 2024 11:06
github-actions bot pushed a commit that referenced this pull request Jun 7, 2024
## [2.11.3](v2.11.2...v2.11.3) (2024-06-07)

### Bug Fixes

* add referer ([#190](#190)) ([68b75d6](68b75d6))
Copy link

github-actions bot commented Jun 7, 2024

🎉 This PR is included in version 2.11.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kptdobe kptdobe mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants