Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(modules): make code a bit more compact #302

Closed
wants to merge 1 commit into from
Closed

Conversation

trieloff
Copy link
Contributor

No description provided.

Copy link

aem-code-sync bot commented Oct 16, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@adobe-bot
Copy link
Collaborator

This PR will trigger no release when merged.

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c8e9388) to head (9a967f6).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #302   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          576       587   +11     
=========================================
+ Hits           576       587   +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kptdobe
Copy link
Contributor

kptdobe commented Oct 16, 2024

I am not a big fan of this but could be a way to gain more bytes. See my proposal here: #303

@trieloff trieloff closed this Oct 16, 2024
@kptdobe kptdobe deleted the minify branch October 16, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants