fix: do not process duplicate navigation checkpoints #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
aem-code-sync
bot
temporarily deployed
to
duplicate-navigation-checkpoints
trieloff
approved these changes
Dec 11, 2024
Co-authored-by: Lars Trieloff <[email protected]>
aem-code-sync
bot
temporarily deployed
to
duplicate-navigation-checkpoints
|
This PR will trigger a patch release when merged. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
+ Coverage 86.74% 86.81% +0.06%
==========================================
Files 6 6
Lines 596 599 +3
==========================================
+ Hits 517 520 +3
Misses 79 79 ☔ View full report in Codecov by Sentry. |
adobe-bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
## [2.26.2](v2.26.1...v2.26.2) (2024-12-11) ### Bug Fixes * do not process duplicate navigation checkpoints ([#331](#331)) ([4b6843f](4b6843f))
|
🎉 This PR is included in version 2.26.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe bundles with multiple
enterandreloadcheckpoints. While this does not seem to be critical, it is not necessary to post them twice.Background: for unknown reason, the PerformanceObserver captures the events twice. The buffering seems to be the root cause but disabling the buffering might lead to losing some of the events.