Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Enhance click checkpoint to cover focus events #334

Closed
wants to merge 3 commits into from
Closed

Conversation

vdua
Copy link
Collaborator

@vdua vdua commented Dec 12, 2024

Enhanced click checkpoint for the following elements inside a form

  • input/select/textarea/button :
  • elements with contenteditable attribute

Open:

  • elements outside the form element : haven't seen the requirement to track those elements for now.
  • click triggers two click checkpoints now : one for focus and another for click. One way to differentiate them is add a target property in the click checkpoint when mapping it for focus.

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

#332

Thanks for contributing!

Copy link

aem-code-sync bot commented Dec 12, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@vdua vdua requested a review from trieloff December 12, 2024 04:36
@vdua vdua closed this Dec 12, 2024
@vdua vdua deleted the focus branch December 12, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant