feat: use remove() for rmdir() #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
| result.Errors.push(...res.Errors); | ||
| errors += res.Errors.length; | ||
| } | ||
| oks += chunk.length; |
There was a problem hiding this comment.
still add this to oks, even when res.Errors is non empty?
There was a problem hiding this comment.
maybe we should update the oks also depending on the result
| const input = { | ||
| Bucket: bucket, | ||
| Delete: { | ||
| Objects: chunk.map((p) => ({ Key: sanitizeKey(p) })), |
There was a problem hiding this comment.
when passing through rmdir to remove, the paths are already sanitized, but eventually removing a leading / is probably not that expensive
There was a problem hiding this comment.
yes. I thought so, too.
dominique-pfister
approved these changes
Oct 11, 2024
adobe-bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
# [@adobe/helix-shared-storage-v1.1.0](https://github.com/adobe/helix-shared/compare/@adobe/helix-shared-storage-v1.0.9...@adobe/helix-shared-storage-v1.1.0) (2024-10-11) ### Features * use remove() for rmdir() ([#1014](#1014)) ([0d4ce8b](0d4ce8b))
|
🎉 This PR is included in version @adobe/helix-shared-storage-v1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.