Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable form submission for isPending #7498

Merged
merged 10 commits into from
Dec 19, 2024

Conversation

snowystinger
Copy link
Member

Closes
from #6197

This will disable implicit and explicit form submission for pending buttons of type="submit"

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@mjawhariPT
Copy link

Apologies as I'm not familiar with how this organization handles PRs, but do you know when this change might go live? Are PRs usually bundled together into updates on a monthly basis for example? Thanks

@snowystinger
Copy link
Member Author

@mjawhariPT first we need to fix the failing tests, then it'll be reviewed by two people on the team. For more information about our releases, see our docs https://react-spectrum.adobe.com/Support.html#release-schedule

@rspbot
Copy link

rspbot commented Dec 15, 2024

ktabors
ktabors previously approved these changes Dec 17, 2024
Copy link
Member

@ktabors ktabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closest I found to testing this in storybook or docs was S2 Button with the submit and isPending prop and seeing the blocker button render.

@rspbot
Copy link

rspbot commented Dec 17, 2024

@rspbot
Copy link

rspbot commented Dec 17, 2024

@rspbot
Copy link

rspbot commented Dec 18, 2024

@snowystinger snowystinger added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 50c7ada Dec 19, 2024
30 checks passed
@snowystinger snowystinger deleted the fix-disable-submitting-isPending branch December 19, 2024 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants