-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable form submission for isPending #7498
Conversation
Apologies as I'm not familiar with how this organization handles PRs, but do you know when this change might go live? Are PRs usually bundled together into updates on a monthly basis for example? Thanks |
@mjawhariPT first we need to fix the failing tests, then it'll be reviewed by two people on the team. For more information about our releases, see our docs https://react-spectrum.adobe.com/Support.html#release-schedule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closest I found to testing this in storybook or docs was S2 Button with the submit and isPending prop and seeing the blocker button render.
Closes
from #6197
This will disable implicit and explicit form submission for pending buttons of type="submit"
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: