Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Next batch of aria utils (Listbox, Tabs, Tree) #7505

Merged
merged 13 commits into from
Dec 13, 2024

Conversation

LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Dec 10, 2024

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@LFDanLu LFDanLu changed the base branch from main to test_util_docs December 10, 2024 23:30
@rspbot
Copy link

rspbot commented Dec 10, 2024

@rspbot
Copy link

rspbot commented Dec 12, 2024

@rspbot
Copy link

rspbot commented Dec 12, 2024

@rspbot
Copy link

rspbot commented Dec 12, 2024

modified some of the utils for consistency, but otherwise kept most of it the same. Changes to be discussed
@rspbot
Copy link

rspbot commented Dec 13, 2024

@LFDanLu LFDanLu marked this pull request as ready for review December 13, 2024 22:28
@LFDanLu LFDanLu changed the title feat: (WIP) Next batch of aria utils feat: Next batch of aria utils Dec 13, 2024
@LFDanLu LFDanLu changed the title feat: Next batch of aria utils feat: Next batch of aria utils (Listbox, Tabs, Tree) Dec 13, 2024
@rspbot
Copy link

rspbot commented Dec 13, 2024

@rspbot
Copy link

rspbot commented Dec 13, 2024

## API Changes

@react-aria/test-utils

/@react-aria/test-utils:User

 User {
   advanceTimer: UserOpts['advanceTimer']
   constructor: (UserOpts) => void
-  createTester: (T, ObjectOptionsTypes<T>) => ObjectType<T>
-  interactionType: UserOpts['interactionType']
-  user: any
+  createTester: (T, TesterOpts<T>) => Tester<T>
+  interactionType: UserOpts['interactionType'] = mouse
 }

/@react-aria/test-utils:UserOpts

 UserOpts {
   advanceTimer?: (number) => void | Promise<unknown>
-  interactionType?: 'mouse' | 'touch' | 'keyboard'
+  interactionType?: 'mouse' | 'touch' | 'keyboard' = mouse
 }

@react-spectrum/test-utils

/@react-spectrum/test-utils:User

 User {
   advanceTimer: UserOpts['advanceTimer']
   constructor: (UserOpts) => void
-  createTester: (T, ObjectOptionsTypes<T>) => ObjectType<T>
-  interactionType: UserOpts['interactionType']
-  user: any
+  createTester: (T, TesterOpts<T>) => Tester<T>
+  interactionType: UserOpts['interactionType'] = mouse
 }

/@react-spectrum/test-utils:UserOpts

 UserOpts {
   advanceTimer?: (number) => void | Promise<unknown>
-  interactionType?: 'mouse' | 'touch' | 'keyboard'
+  interactionType?: 'mouse' | 'touch' | 'keyboard' = mouse
 }

@LFDanLu LFDanLu merged commit 2f90006 into test_util_docs Dec 13, 2024
32 checks passed
@LFDanLu LFDanLu deleted the next_batch_of_utils branch December 13, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants