fix: prod docs #7523
Merged
fix: prod docs #7523
+502
−494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
commented
Dec 16, 2024
| "recast": "^0.23.9", | ||
| "ts-node": "^10.9.2", | ||
| "uuid": "^9.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@types/jscodeshift": "^0.11.11", | ||
| "react-dom": "^16.8.0 || ^17.0.0-rc.1 || ^18.0.0 || ^19.0.0", |
There was a problem hiding this comment.
These appear to be unused. React is only used for types.
reidbarber
approved these changes
Dec 16, 2024
LFDanLu
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues in verdaccio docs build on main:
"main": false), parcel was no longer parsing the package and failing to resolve it. This is addressed in Parcel v2.13.3.The root issue is that we don't have a lock file in the prod build, which we should definitely fix at some point.