Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run time comparisons taking account of possible clock skew #21

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Run time comparisons taking account of possible clock skew #21

merged 5 commits into from
Oct 31, 2024

Conversation

IngridPuppet
Copy link
Collaborator

@IngridPuppet IngridPuppet commented Oct 28, 2024 •
edited
Loading

Closes #20

In a nutshell:

  • Completely remove iat checks beyond emptying the corresponding method definition.
  • Introduce a configurable leeway for nbf and exp checks.

@IngridPuppet IngridPuppet linked an issue Oct 28, 2024 that may be closed by this pull request
Review: Disable unreliable check between current times of different systems #17 #20
Closed
@Ogenbertrand Ogenbertrand merged commit ea1ec91 into develop Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ogenbertrand Ogenbertrand Ogenbertrand approved these changes

@hugoib hugoib Awaiting requested review from hugoib

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review: Disable unreliable check between current times of different systems #17
2 participants
@IngridPuppet @Ogenbertrand