Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibraryItemController #3607

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

unl0ck
Copy link

@unl0ck unl0ck commented Nov 12, 2024

Added Missed LibraryItemController
Added media to LibraryItemBase

@unl0ck
Copy link
Author

unl0ck commented Nov 14, 2024

@advplyr @nichwall is this correct ?

@nichwall
Copy link
Contributor

nichwall commented Nov 14, 2024

I haven't sat down and gone through it.

There is also #3198 which adds a lot of new things to the OpenAPI spec for the current API. Vito found issues with the current API from the server (some discussion in that PR). Some OpenAPI generators were having issues with the spec due to many oneOf, anyOf, and allOf.

I have been working on defining a new API in #3388 off and on to help address this and prepare for migrating to a new API which matches the underlying data model a lot more.

Edit: clarifications

@unl0ck
Copy link
Author

unl0ck commented Nov 14, 2024

@nichwall so is it possible to release a current state of #3198 ? also maybe it is better to create an own repository for the openapi ?

@nichwall
Copy link
Contributor

@nichwall so is it possible to release a current state of #3198 ? also maybe it is better to create an own repository for the openapi ?

It will be a few days before I can look at it again. If you want to look at it and help clean up any issues with the PR to simplify the review process that could be good. I did not finish going through everything since there were issues that Vito mentioned.

Eventually the OpenAPI docs will replace https://github.com/audiobookshelf/audiobookshelf-api-docs for hosting as a website, but the OpenAPI spec will remain in this repo once it's fully defined so the spec can remain up to date with the server.

All of this has been in flux for multiple months since there are multiple moving parts and dev time is limited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants