Adds a configuration for podcast feed and episode download timeout #3771
+8
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The env variable should be specific to podcast file downloads unless it is also used for cover image downloads. |
|
Sure, I can rename the env variable to PODCAST_DOWNLOAD_TIMEOUT if you would prefer. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary
Added a new global configuration PODCAST_DOWNLOAD_TIMEOUT to configure the axios timeout for Podcast feed and episode downloads. The value defaults to the same 30000ms as before if not set, but can now be overridden, or set to 0 to disable timeouts all together.
Which issue is fixed?
Fixes #3662
In-depth Description
I've been experimenting with podly_pure_podcasts to remove ads from Podcast episodes. This results in really long download times as the podly server processes the episode, causing downloads in Audiobookshelf to timeout.
How have you tested this?
Tested by running locally, configuring the timeout to 0, downloading an episode through the podly server, and confirming the download does not timeout.
All tests pass when running
npm run testScreenshots
N/A