Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The declarative way to flush redis for our dashboard #24

Merged
merged 2 commits into from
Feb 19, 2024
Merged

The declarative way to flush redis for our dashboard #24

merged 2 commits into from
Feb 19, 2024

Conversation

kvaps
Copy link
Member

@kvaps kvaps commented Feb 19, 2024 •
edited
Loading

This PR moves imperative logic of flushing redis from installer.sh to be declarative in platform chart.
Thus now redis will be restarted every time when the flux saves a new artifact for helmrelease in cozy-public namespace:

  values:
    kubeapps:
      redis:
        master:
          podAnnotations:
            repository.cozystack.io/cozystack-apps: "sha256:29222315d063ffede0e09e3d6a24549b3f818fd025646d52e938f4477098a1d1"
            repository.cozystack.io/cozystack-extra: "sha256:77381c0662e86398c8fcf53dfb82535cb328cfea38d1351cb220016e5ebe9ba1"

This logic is not critical, and used only to show actual infromation about the charts in our dashboard.

This is temporary solution but still a better than already existing now. Hopefully we'll refactor it in a while.

fixes #19

@kvaps kvaps changed the title the declarative way to flush redis Еhe declarative way to flush redis for dashboard Feb 19, 2024
@kvaps kvaps changed the title Еhe declarative way to flush redis for dashboard The declarative way to flush redis for dashboard Feb 19, 2024
@kvaps kvaps changed the title The declarative way to flush redis for dashboard The declarative way to flush redis for our dashboard Feb 19, 2024
@kvaps kvaps self-assigned this Feb 19, 2024
@kvaps kvaps requested review from gecube and egeneralov February 19, 2024 15:11
@s3rj1k s3rj1k self-requested a review February 19, 2024 15:45
s3rj1k
s3rj1k approved these changes Feb 19, 2024
View reviewed changes
Copy link

@s3rj1k s3rj1k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, much better than bash solution

gecube
gecube approved these changes Feb 19, 2024
View reviewed changes
Copy link
Collaborator

@gecube gecube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anyway we need to post a bug issue to kubeapps project.

@kvaps
Copy link
Member Author

kvaps commented Feb 19, 2024

anyway we need to post a bug issue to kubeapps project.

Sure, I just sent it to upstream
vmware-tanzu/kubeapps#7500

@kvaps kvaps merged commit 235a2fc into main Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egeneralov egeneralov egeneralov approved these changes

@s3rj1k s3rj1k s3rj1k approved these changes

@gecube gecube gecube approved these changes

Assignees

@kvaps kvaps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move kubeapps cache reloading logic out of installer.sh
4 participants
@kvaps @gecube @s3rj1k @egeneralov