fix: optimistic response id check fixed

aerogear · May 15, 2019 · 73b5b1e · 73b5b1e
1 parent b2aff3c
commit 73b5b1e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/sync/src/cache/createMutationOptions.ts b/packages/sync/src/cache/createMutationOptions.ts
@@ -19,11 +19,19 @@ export const createMutationOptions = (options: MutationHelperOptions): MutationO
     mutation,
     variables,
     updateQuery,
+    typeName,
     operationType = CacheOperation.ADD,
     idField = "id"
   } = options;
   const operationName = getOperationFieldName(mutation);
-  const optimisticResponse = createOptimisticResponse(options);
+  const optimisticResponse = createOptimisticResponse({
+    mutation,
+    variables,
+    updateQuery,
+    operationType,
+    idField,
+    typeName
+  });
 
   const update = getUpdateFunction(operationName, idField, updateQuery, operationType);
   return { mutation, variables, optimisticResponse, update };

diff --git a/packages/sync/src/cache/createOptimisticResponse.ts b/packages/sync/src/cache/createOptimisticResponse.ts
@@ -59,7 +59,7 @@ export const createOptimisticResponse = (options: MutationHelperOptions) => {
       ...variables,
       optimisticResponse: true
     };
-    if (operationType !== CacheOperation.REFRESH) {
+    if (operationType === CacheOperation.ADD) {
       optimisticResponse[operation][idField] = generateId();
     }