fixing dc and xdr stat collection #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #63 +/- ##
==========================================
- Coverage 36.24% 35.06% -1.18%
==========================================
Files 23 23
Lines 5615 5592 -23
==========================================
- Hits 2035 1961 -74
- Misses 3441 3500 +59
+ Partials 139 131 -8 ☔ View full report in Codecov by Sentry. |
a-spiker
reviewed
Nov 28, 2024
| func GetASConfig(path *string, conn *deployment.ASConn, aerospikePolicy *aero.ClientPolicy) ( | ||
| confToReturn interface{}, err error) { | ||
| func GetASConfig(paths []string, conn *deployment.ASConn, aerospikePolicy *aero.ClientPolicy) ( | ||
| confToReturn map[string]interface{}, err error) { | ||
| h := aero.Host{ | ||
| Name: conn.AerospikeHostName, | ||
| Port: conn.AerospikePort, | ||
| TLSName: conn.AerospikeTLSName, | ||
| } | ||
| asinfo := info.NewAsInfo(conn.Log, &h, aerospikePolicy) |
There was a problem hiding this comment.
Kindly close the connection opened by the client, there is a connection leak
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.