-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Om139 #84
Om139 #84
Conversation
modified queries according to the 7.0 stat and metrics added all-cluster master-object and unique-usage-bytes view which are all connected to a prometheus instance
added historical view for all-cluster rows,
modified alert-panel to display as a pie chart
fixed url link bug
corrected wrong checking of unique data view. this unique-data is taken as part of jira-129
1. modified diagram constructing query to use only cluster-name, dc and ns - as we dont require to show connector types - (simplified overall query) 2. used max in xdr_lag instead of sum 3. added separate query to show server without any xdr-connections 4. updated panel title to show total / max
fixed query to use only cluster-name, dc and ns added a join with objects to add diagrams even if there is no XDR configured added extra query and variable to show different images for server and connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modified alerts query to consider only "critical" severity fixed alert url link
modified alert query to consider only "critical" severity while showing color in Node (Hex) and Namespace panels |
removed alert- severity filter variable also, as it is no more required |
modified alert severity to use critical, warn or error during display
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think version 7941947 was better. If we can only choose two colors it should be red (with hardcoded critical filter) or green for no critical.
keeping only RED colour, however using only "critical", mean some key alerts which are marked as warn / error (example XDRTimelag a warn alert) will not show any indication, may leave user with assumption of all-is-good. |
modified alert-severity level to "critical" and "warn" in all 3 panels ( world-map, nodes and namespace) removed un-used queries as fixed alert-severity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK with this version.
7.0 changes - initial changes to support multi-cluster view