-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transport & Engine: AsyncTransport
plugin
#6626
base: main
Are you sure you want to change the base?
Changes from 12 commits
b59d999
0c42841
6cb4d9e
14cbd29
e9361bb
6811098
5fdde51
ccc545e
f187fdc
565724d
6e350e7
03ccc30
178bf7b
cc0bc5c
3210c27
76aaf53
65f0663
a809b98
38cfc24
799e0f8
665a163
0837193
1b96110
3aa0031
a68240c
520e58e
22eb929
90718f4
343cf9c
482eeca
5e29e5b
a5ff84d
1761d94
cf01ac0
6627b21
2ebf945
fb384ac
d6176fd
1e78d7f
1b8bbd5
5e282d4
942690c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,12 +4,13 @@ | |||||
|
||||||
import tempfile | ||||||
from pathlib import Path | ||||||
from typing import Union | ||||||
|
||||||
from aiida.orm import CalcJobNode | ||||||
from aiida.transports import Transport | ||||||
from aiida.transports import AsyncTransport, Transport | ||||||
|
||||||
|
||||||
def always_kill(node: CalcJobNode, transport: Transport) -> str | None: | ||||||
def always_kill(node: CalcJobNode, transport: Union['Transport', 'AsyncTransport']) -> str | None: | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same for other places, but it is fine to leave it as this, I think we will find a time to change them all. So please ignore my comment above. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, at first I also had them as |
||||||
"""Retrieve and inspect files in working directory of job to determine whether the job should be killed. | ||||||
|
||||||
This particular implementation is just for demonstration purposes and will kill the job as long as there is a | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you make a PR there so we can do a new release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes! Please review here: aiidateam/plumpy#272