-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set pytest timeout to 60s for every test #6674
Conversation
not a single test should longer than 30s, if it happens something hang up, go and fix it.
for more information, see https://pre-commit.ci
This change reveal some very slow tests which we may want to improve the test case or tag them with "slow" mark and run separately. |
As far as I see that is only the |
Maybe we can just put the timeout to 60s to have a large gap. If the tests just fail because the CI is a bit slower on that particular day, this becomes more annoying than useful. That should also cover the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6674 +/- ##
=======================================
Coverage 77.94% 77.94%
=======================================
Files 563 563
Lines 41761 41761
=======================================
Hits 32545 32545
Misses 9216 9216 ☔ View full report in Codecov by Sentry. |
not a single test should longer than 30s, if it happens something hang up, go and fix it.