Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incorrect typing changes #10222

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Dec 23, 2024

From #9528. This should work again with mypy 1.14.

Add some new flags too.

@Dreamsorcerer Dreamsorcerer added bot:chronographer:skip This PR does not need to include a change note backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (f52ec5c) to head (6eed0f0).
Report is 9 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10222      +/-   ##
==========================================
- Coverage   98.77%   98.77%   -0.01%     
==========================================
  Files         122      122              
  Lines       37029    37028       -1     
  Branches     2041     2041              
==========================================
- Hits        36577    36573       -4     
- Misses        313      316       +3     
  Partials      139      139              
Flag Coverage Δ
CI-GHA 98.66% <100.00%> (-0.01%) ⬇️
OS-Linux 98.34% <100.00%> (-0.01%) ⬇️
OS-Windows 96.21% <100.00%> (-0.01%) ⬇️
OS-macOS 97.46% <100.00%> (-0.01%) ⬇️
Py-3.10.11 97.34% <100.00%> (-0.01%) ⬇️
Py-3.10.15 97.92% <100.00%> (-0.01%) ⬇️
Py-3.11.11 98.01% <100.00%> (+0.04%) ⬆️
Py-3.11.9 97.43% <100.00%> (-0.01%) ⬇️
Py-3.12.8 98.43% <100.00%> (-0.01%) ⬇️
Py-3.13.1 98.42% <100.00%> (-0.01%) ⬇️
Py-3.9.13 97.23% <100.00%> (-0.01%) ⬇️
Py-3.9.20 97.80% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 97.38% <100.00%> (-0.01%) ⬇️
VM-macos 97.46% <100.00%> (-0.01%) ⬇️
VM-ubuntu 98.34% <100.00%> (-0.01%) ⬇️
VM-windows 96.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #10222 will not alter performance

Comparing Dreamsorcerer-patch-1 (6eed0f0) with master (f52ec5c)

Summary

✅ 47 untouched benchmarks

@Dreamsorcerer
Copy link
Member Author

Pending dependabot PR, which should catch up over the next 2 days.

@webknjaz
Copy link
Member

Pending dependabot PR, which should catch up over the next 2 days.

@Dreamsorcerer alternatively we could just bump all the deps manually, with a local pip-tools run. And avoid those annoying Dependabot notifications coming in every day..

@asvetlov
Copy link
Member

Sorry, guys, I've missed what are you talking about.
@webknjaz do you want to disable dependabot for the project?

@Dreamsorcerer
Copy link
Member Author

Pending dependabot PR, which should catch up over the next 2 days.

@Dreamsorcerer alternatively we could just bump all the deps manually, with a local pip-tools run. And avoid those annoying Dependabot notifications coming in every day..

I'm just being lazy. Could have also manually triggered Dependabot. I think using Dependabot is still preferable, but would be great to filter out those notifications...

@webknjaz
Copy link
Member

do you want to disable dependabot for the project?

No, not right now anyway. The problem is that it was stuck for a while, and Sam fixed it just the other day. Now it's trying to catch up by creating a gazillion of PRs, one per each dependency. It calls pip-compile under the hood. A more efficient way could be running it manually to bump everything just this once, so dependabot would be less noisy.

The current setup is not very flexible and has a number of issues in the space of package management, so it's possible to fundamentally rework it, but it requires a certain amount of focused effort. This is why I'm not jumping right into it, even though I've done this research multiple times elsewhere and have really good practices that work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants