-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert incorrect typing changes #10222
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #10222 +/- ##
==========================================
- Coverage 98.77% 98.77% -0.01%
==========================================
Files 122 122
Lines 37029 37028 -1
Branches 2041 2041
==========================================
- Hits 36577 36573 -4
- Misses 313 316 +3
Partials 139 139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #10222 will not alter performanceComparing Summary
|
Pending dependabot PR, which should catch up over the next 2 days. |
@Dreamsorcerer alternatively we could just bump all the deps manually, with a local pip-tools run. And avoid those annoying Dependabot notifications coming in every day.. |
Sorry, guys, I've missed what are you talking about. |
I'm just being lazy. Could have also manually triggered Dependabot. I think using Dependabot is still preferable, but would be great to filter out those notifications... |
No, not right now anyway. The problem is that it was stuck for a while, and Sam fixed it just the other day. Now it's trying to catch up by creating a gazillion of PRs, one per each dependency. It calls The current setup is not very flexible and has a number of issues in the space of package management, so it's possible to fundamentally rework it, but it requires a certain amount of focused effort. This is why I'm not jumping right into it, even though I've done this research multiple times elsewhere and have really good practices that work. |
From #9528. This should work again with mypy 1.14.
Add some new flags too.