-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opensearch): implement support for opensearch acls #316
Conversation
hey, @mortenlj! 👋 thank you for your contribution! it is possible to manage the OpenSearch ACLs via the ElasticSearch API, have you tried to use it? this is the way our Terraform provider manages them; I'm not sure if we would want to have duplicates of the similar endpoints |
No, didn't try as the Elasticsearch API isn't documented anywhere. I see now that it works.
For what it's worth, keeping the client code for a product you no longer offer while not having client code for the product that has replaced it seems somewhat of a strange choice. 🙂 |
also, I suggest that you update ElasticSearch part of the client and mark the methods as deprecated |
hmm, looks like |
ce918f2
to
77bd795
Compare
Tried doing that, only to now realize I've picked up a random dependabot commit on the way. Not sure how to undo that, my git fu isn't that strong ... |
hey, @mortenlj! 👋 I could fix it for you if you allow edits of this PR for maintainers in the PR |
77bd795
to
614d52b
Compare
I couldn't find that option, but got some help with the git commands and managed to fix it I believe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Fixes #315