feat: add ability to disable connection info secret creation #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rriski
force-pushed
the
rriski-optionally-disable-conninfosecret
branch
9 times, most recently
from
66ad1e4 to
3fe621f
Compare
rriski
force-pushed
the
rriski-optionally-disable-conninfosecret
branch
from
3fe621f to
6cfd938
Compare
byashimov
requested changes
Jan 25, 2024
Grafana is faster to provision and we don't care about service type in these tests.
rriski
force-pushed
the
rriski-optionally-disable-conninfosecret
branch
from
6cfd938 to
6e7334d
Compare
rriski
force-pushed
the
rriski-optionally-disable-conninfosecret
branch
from
6e7334d to
35ed541
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
connInfoSecretTargetDisabledfield to resources that generate connection info secrets.The following restrictions apply:
connInfoSecretTargetDisabledcan only be set on newly created resourcesconnInfoSecretTargetDisabledcannot be mutated once setThese restrictions are in place due to the following factors because we don't want to delete secrets of previously created resources that may be depended on. For the same reason, we don't allow mutating the field once set so as to not delete secrets. In theory, we could allow changing the value from
truetofalse, which would have the effect of 1) not creating the secret at resource provisioning time becauseconnInfoSecretTargetDisabled: trueand 2) at update time, the secret would be created. We decided to not implement this behaviour at this time.Resolves #541